Add unit tests for SpellCheckerManager and refactor core logic #1338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce tests for `SpellCheckerManager` to validate dictionary paths, language handling, and fallback mechanisms. Refactor `SpellCheckerManager` to allow instance-based usage and integrate it into the core for easier testability and better design. Additionally, update dependencies to include Mockito for mocking in unit tests. Signed-off-by: Hiroshi Miura <miurahr@linux.com>
|
❌ Quality checks failed. Please look a Gradle Scan page for details: |
Organized import statements by removing wildcard imports and adding specific ones for better clarity and maintainability. Also ensured the file ends with a newline for consistency with coding standards. Signed-off-by: Hiroshi Miura <miurahr@linux.com>
|
In the previous, |
…est-spell-check-manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
refactor
Which ticket is resolved?
There is no issue to point
What does this PR change?
SpellCheckerManager#getCurrentSpellCheckeras instance method for testability.Other information